Fixes to Csv import Exports

[lesmar54]

Part of the fixing of csv files for import and export

[lesmar54]

Merged all of the fixes into one patch now

[FatihKoz]

If you fix the style error, I think they will pass the build tests

[lesmar54]

corrected spacing for public static and spaces after callsign column

[lesmar54]

Done the changes to align the public static and remove two spaces after callsign ’nullable’,

…

On 6 Sep 2021, at 21:27, B.Fatih KOZ ***@***.***> wrote: <https://user-images.githubusercontent.com/74361521/132248926-f5b20dea-6206-42a1-a137-1d4d663ad5ec.png> If you fix the style error, I think they will pass the build tests — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1299 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJ7CEDBUNYEDSMBJ5SUCZ3UAT2XBANCNFSM5DNNTTXQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[FatihKoz]

You still have styling errors.

[lesmar54]

You still have styling errors.

I went to the edit file and aligned PUBLIC but do not understand where the style issue is now

[lesmar54]

Passed the styling at last I think

[FatihKoz]

Yes, now the owner of the main repository ( phpvms / nabeel ) can allow other checks to be executed for this.

This needs manual input at the moment but when you reach to a level all will be automatically done and then the owner will just check and decide what to do (if your changes pass all checks of course).

Now you can safely close all those other "single file" pull requests, they are not needed anymore 'cause all is here ;)

[nabeelio]

Some tests are still failing, I can take a look in a little bit.

[FatihKoz]

Yeah, flights_empty_fields.csv this one needs to updated too. It is causing the import test to fail.

[FatihKoz]

There may be more files to edit though, just checked the tests/data folder. All files regarding aircraft / flights / subfleets needs to edited according to the new field requirements.

[lesmar54]

Ok I will look at these other csv files in the morning now I know how to AC filed to a pr

…

Sent from my iPad

On 7 Sep 2021, at 18:56, B.Fatih KOZ ***@***.***> wrote:  There may be more files to edit though, just checked the tests/data folder. All files regarding aircraft / flights / subfleets needs to edited according to the new field requirements. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[nabeelio]

Yeah just add onto this PR

[lesmar54]

3 other csv files added to PR