Temperature widget #1332
Temperature widget #1332
Conversation
Add temp "es" string @lang temp to widget wheather blade
| @@ -51,7 +51,7 @@ | |||
| <tr> | |||
| <td>Temperature</td> | |||
| <td> | |||
| @if($metar['temperature'][$unit_temp]) {{ $metar['temperature'][$unit_temp] }} @else 0 @endif °{{strtoupper($unit_temp)}} | |||
| @if($metar['temperature'][$unit_temp]), @lang('widgets.weather.temp') {{ $metar['temperature'][$unit_temp] }} @else 0 @endif °{{strtoupper($unit_temp)}} | |||
There was a problem hiding this comment.
I think this should not be here, instead it should be at line 52.
So the table row will start with Temperatura then it will show the value like 32 and go on with , Punto de rocio 28 and so on.
What will happen with this code is like below
Temperature | Temperatura 32, Punto de rocio 28, Humedad %80
So the table row will still be using English on the left.
There was a problem hiding this comment.
And the worst part of this happens for English users, they will see the widget like this
Temperature | Temperature 32, Dewpoint 38, Humidity %80 :(
There was a problem hiding this comment.
Ah shoot, sorry, I thought this was all tested already. @arv187 can you submit another PR to fix
There was a problem hiding this comment.
Thanks, no problem.
Add temp "es" string.
@lang temp to widget wheather blade.
Please, check if code is right.