Eager loading update for frontend controllers and widgets #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eager load `files`
Eager load `journal` for user , and `aircraft, arr_airport, comments, dpt_airport` for last_pirep.
Eager load + `alt_airport, subfleets` (with their airlines) for flights and `current_airport` for user (though current_airport can be removed and we can base the in blade checks on `$user->curr_airport_id` to reduce db reads and model loading)
Eager load `home_airport` for users
Eager load `airline, aircraft, fares, transactions, dpt_airport, arr_airport, comments, simbrief, user with rank` for pirep details
Eager load `airline, awards, current_airport, fields.field, home_airport, last_pirep, rank` for user
Eager load `airline, current_airport, fields.field, home_airport, rank` for users and count `awards`
Eager load `user` for news
Eager load `home_airport` for latest users
Eager load airline with flight
|
Some conflicts that need to be fixed |
|
Damn, why :( Because I did some changes on the profile controller with previous pr. Although this fine tunes it but, it is how it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practically eager loaded items needed for detailed display of flights and pireps, users etc.