Create FlightRouteAwards.php #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the Admins to create an Award that will be granted if a Pilot completes a flight with a defined Departure and Arrival Airport. So allowing a Reward for a particular Flight. This should solve issue #860
Correcting some PHP Style Errors/Suggestions
Still trying to clean-up the php Style to make the Checker Happy
Changed a "Hard Coded" test that only allowed 2 Awards, this is a test to see if the "assertCount()" will allow ">=2" rather than a full interger
assertCount() seems to only allow a full int, so we may need to find a better method for the unit test to make sure it can see more than the 2 included Awards
nabeelio
reviewed
Oct 12, 2020
nabeelio
reviewed
Oct 12, 2020
This should solve the hard coded issue with the assertCount() method
Correcting the in-line documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Admins to create an Award that will be granted if a Pilot completes a flight with a defined
Departure and Arrival Airport.
So allowing an Award for a particular Flight.
This should solve issue #860