Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aws-sdk-go-v2 #75

Merged
merged 5 commits into from
Apr 20, 2024
Merged

Migrate to aws-sdk-go-v2 #75

merged 5 commits into from
Apr 20, 2024

Conversation

fudanchii
Copy link
Contributor

@fudanchii fudanchii commented Mar 18, 2024

This PR contains breaking change so we likely want to bump the major version.

Changes:

  • aws-sdk-go-v2 now removes builtin interface for APIs, internalize the interface at internal/sqsiface so we can keep the testability intact.
  • aws-sdk-go-v2 now removes builtin types and use Go primitives directly, also downgraded int64 to int32 for most of the int type, this PR comply with this change.
  • all public methods now accept context.Context. We keep the old -WithContext pattern for easier migration. Follow the new pattern and removed all -WithContext methods.

@nabeken nabeken self-requested a review March 28, 2024 05:53
@nabeken nabeken changed the base branch from master to prep-v4 March 31, 2024 07:08
@nabeken
Copy link
Owner

nabeken commented Mar 31, 2024

@fudanchii Thank you for your work!

I've updated the base branch to prep-v4 so we can do more work without landing actual changes into master.

all public methods now accept context.Context. We keep the old -WithContext pattern for easier migration.

Yeah, but we can only have a chance to do breaking changes now so I would like to remove the old WithContext methods and requires context.Context in the exposed methods.

@fudanchii
Copy link
Contributor Author

Yeah, but we can only have a chance to do breaking changes now so I would like to remove the old WithContext methods and requires context.Context in the exposed methods.

@nabeken Understood, I removed the -WithContext methods with the latest change 🙏

@nabeken nabeken merged commit f129678 into nabeken:prep-v4 Apr 20, 2024
@nabeken
Copy link
Owner

nabeken commented Apr 20, 2024

@fudanchii Thank you for your support! I've incorporated the PR into #85 and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants