-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update crates versions (especially, git2) #165
Closed
igxactly
wants to merge
1
commit into
nabijaczleweli:master
from
igxactly-forks:fix-git_update-crates
Closed
Update crates versions (especially, git2) #165
igxactly
wants to merge
1
commit into
nabijaczleweli:master
from
igxactly-forks:fix-git_update-crates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see how this is compatible with the 1.35.0 compatibility guarantee?
This looks like you have a broken system more than anything wrong with end-user applications? |
@nabijaczleweli Sorry, my PR was too naive. I didn't consider about older version compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problem installing cargo-update using "cargo install cargo-update" with aarch64-darwin rust toochain setup.
It seems there has been some issues about finding and including/linking iconv library resources, when there is libiconv installed through macports.
I tried to update git2-rs and some other packages that does not break build and test, and it worked. (Though there was some comment of someone who solved problem by deactivating macports libiconv. I did not deactivate it, and did update
cargo.toml
)