-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cryptography #400
Comments
FWIW I'd like to add my vote to this. I'm running in to ASN1 decode issues which seem to be resolved in Cryptography 2.8 as per pyca/cryptography#3542 |
@nabla-c0d3 are you aware of any work around for this issue? My main issue is that having set off a scan for a large number of domains it will fail at the point of JSON creation but I won't know what domain it is that is causing it all to fail. I've actually had a number of various (but seemingly related failures) that all have the same outcome - I don't know what domain caused the issue...
If I could identify which domain had caused the failure I could skip it for now. Is there a way to have the problematic domain (cert name) in the output when it fails? (Even better would be if it could just log and skip this domain and then continue with the output). |
I installed sslyze without dependencies and then the latest version of cryptography (or the other way around) (and of course the other dependencies) and had no issues |
Thanks for the suggestion! Are you able to describe the steps that you did to get this to work? I'm on Windows with Python 3.7.4 and used pip to install SSLyze 2.1.4. I then also used pip to forcibly install cryptography 2.8. When I run SSLyze I get...
|
I cannot test on windows but it should make no difference:
|
Really appreciate your help! Sadly this doesn't work as I get a dependency error...
I'll give it a go on my Linux box to see if it's the same... |
Okay, rushed and didn't use venv. Having installed and used venv to install things it to it seems to be working! I'll report back if I hit any more ASN1 issues. Thanks for your help @PhilippSelenium |
Damnit, same issue. I thought that the newest Cryptography library has solved this but, alas, not. Currently trying to figure out the best way to dump the name of the domain that causes the ASN1 > UTF8 error... |
Released with v3.0.0. |
Is your feature request related to a problem? Please describe.
I want to use this module but I require a recent version of cryptography (2.8)
Describe the solution you'd like
change the used version of cryptography == 2.8 or >=2.5
Describe alternatives you've considered
Not using sslyze
Additional context
Regularly update dependencies
The text was updated successfully, but these errors were encountered: