You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
We call SSLyze from some integration tests, parse the JSON report, and make assertions on about protocols/ciphers that we expect to see. The new --mozilla-config functionality conflicts with our use in two ways:
the plaintext output to STDOUT means that json_out=- doesn't produce valid JSON
the exit code of 1, when the Mozilla check is not compliant, is hard to distinguish from other errors
I considered raising these as separate issues but I think it's possible to solve them both at the same time by including the Mozilla report in the JSON output and not changing the exit code when not compliant, so that you can perform your own assertions on the output.
To Reproduce
Parsing the output with jq results in an error when it gets to the Mozilla banner:
$ docker run --rm nablac0d3/sslyze:5.0.0 --json_out=- google.com | jq .sslyze_version ; echo $?
"5.0.0"
parse error: Invalid numeric literal at line 10090, column 12
4
Scanning a server with a self-signed certificate produces a non-zero exit code:
Describe the bug
We call SSLyze from some integration tests, parse the JSON report, and make assertions on about protocols/ciphers that we expect to see. The new
--mozilla-config
functionality conflicts with our use in two ways:json_out=-
doesn't produce valid JSONI considered raising these as separate issues but I think it's possible to solve them both at the same time by including the Mozilla report in the JSON output and not changing the exit code when not compliant, so that you can perform your own assertions on the output.
To Reproduce
Parsing the output with
jq
results in an error when it gets to the Mozilla banner:Scanning a server with a self-signed certificate produces a non-zero exit code:
Expected behavior
These both resulted in zero exit codes in the previously published version:
Additional context
The utility is great and so is the new Mozilla functionality. Thanks!
The text was updated successfully, but these errors were encountered: