Skip to content

Commit

Permalink
Temporarily building with -fno-stack-protector when platform=solo5
Browse files Browse the repository at this point in the history
Right now, rumprun's libc is built with stack protection. It uses thread local
storage (TLS) to store the canary. This is problematic when running on top of
solo5 as it doesn't allow the TLS register (%fs in x84/64) to be set. So, in
this change we temporarily disable stack protection (build with
-fno-stack-protector) until solo5/solo5 adds a solo5 API to set the TLS
register.

Signed-off-by: Ricardo Koller <kollerr@us.ibm.com>
  • Loading branch information
Ricardo Koller committed Jan 29, 2019
1 parent 79c4af3 commit 6a10b78
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build-rr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ buildrump ()
TLSCFLAGS="-F CFLAGS=-DRR_USE_TLS"
else
CURLWP_METHOD=hypercall
TLSCFLAGS="-F CFLAGS=-D_PTHREAD_GETTCB_EXT=_lwp_get_tls_tcb"
TLSCFLAGS="-F CFLAGS=-D_PTHREAD_GETTCB_EXT=_lwp_get_tls_tcb -F CFLAGS=-fno-stack-protector"
fi

extracflags=
Expand Down

0 comments on commit 6a10b78

Please sign in to comment.