Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing internal NameTuple instances with @dataclass usage #29

Closed
wants to merge 1 commit into from

Conversation

nackjicholson
Copy link
Owner

No description provided.

@nackjicholson
Copy link
Owner Author

@xlevus You're the only person I know of that has depended on very very internal things to this library. This shouldn't affect you but I put it in a PR just so you'd be able to easily see the change in case it does break something for you.

@nackjicholson
Copy link
Owner Author

@xlevus Nevermind, this isn't merging. I forgot dataclasses were a py37 feature and this library still supports py36 for now.

@yanniskatsaros
Copy link

If you’d like to continue support for Python 3.6 and still use dataclasses, it can just be added as a pip installable dependency to those users. Here is the back port in case you’d be interested in doing so:

https://pypi.org/project/dataclasses/

@nackjicholson
Copy link
Owner Author

@yanniskatsaros Thanks, I have used that package before. I'm being a bit stubborn not wanting to add it as an install dependency only for 3.6. But I may end up doing that.

@zx80 zx80 deleted the dataclasses-for-internal-namedtuples branch July 10, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants