Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple lines comment #9

Closed
stla opened this issue Feb 13, 2017 · 3 comments
Closed

Multiple lines comment #9

stla opened this issue Feb 13, 2017 · 3 comments
Labels

Comments

@stla
Copy link

stla commented Feb 13, 2017

Hello,

I have this comment in a xlsx file:
capture

tidyxl only returns the first line:

> z$data$Sheet1$comment
 [1] "Stéphane Laurent:" NA                   NA                  
 [4] NA                   NA                   NA                  
 [7] NA                   NA                   NA                  
[10] NA                   NA                   NA 

(the encoding issue can be solved with Encoding(x) <- "UTF-8")

It is encoded like this in the xml file:

        <comment ref="A1" authorId="0">
            <text>
                <r>
                    <rPr><b/><sz val="9"/><color indexed="81"/><rFont val="Tahoma"/><family val="2"/></rPr>
                    <t>Stéphane Laurent:</t>
                </r>
                <r>
                    <rPr><sz val="9"/><color indexed="81"/><rFont val="Tahoma"/><family val="2"/></rPr>
                    <t xml:space="preserve">
                        hello</t>
                </r>
            </text>
        </comment>

It would be nice to get the concatenation of the two lines: Stéphane Laurent\r\nhello.

@stla
Copy link
Author

stla commented Feb 13, 2017

By the way, perhaps comments deserve a separate dataframe to store them (z$comments$Sheet1), since they are styled.

@nacnudus
Copy link
Owner

The multiline bug is fixed in 96df3bd.

Stéphane renders properly in my terminal. Have you tried wrapping it in cat()? If that doesn't work, then please open another issue.

The styling of comments is a duplicate of #5, which I see you have already found.

@stla
Copy link
Author

stla commented Feb 13, 2017

Stéphane renders properly in my terminal. Have you tried wrapping it in cat()?

Yes, this is the same with cat(). Maybe because I'm using Windows, or this is related to the locale. Also µ is rendered as µ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants