Cleanup deprecated Line->input

[lode]

This does a cleanup of the deprecation mark on Line->input.

There's still calls to that property for different reasons I think:

• some places should actually use Line->getInput(): https://github.com/nadar/quill-delta-parser/blob/master/src/listener/Color.php#L28, https://github.com/nadar/quill-delta-parser/blob/master/src/listener/Font.php#L42-L45
• some places actually need the unescaped data: https://github.com/nadar/quill-delta-parser/blob/master/src/listener/Script.php#L48
• some places need to write: https://github.com/nadar/quill-delta-parser/blob/master/src/InlineListener.php#L39

I haven't dived into the tests yet, however all tests are green. That also worries me a little though. While making and debugging I never got failed tests. For example switching Script to use getInput instead, no test breaks. So we probably need to add some tests to make sure this doesn't break anything.

• investigate and make some tests

[nadar]

I did a quick review. This looks good to me.

That also worries me a little though. While making and debugging I never got failed tests. For example switching Script to use getInput instead, no test breaks. So we probably need to add some tests to make sure this doesn't break anything.

Yes, maybe we have to add more tests. Regarding getUnsafeInput in code block, i guess this will explain that behavior:

Note it could be escaped if a previous inline listener updated the input value

[lode]

I did a quick review. This looks good to me.

👍

Yes, maybe we have to add more tests.

I verified all listener changes with new tests. Feels better :)

Regarding getUnsafeInput in code block, i guess this will explain that behavior:

Note it could be escaped if a previous inline listener updated the input value

I was actually wrong about the script listener. I thought it was the <script> element, but it is about <sup>/<sub>. They should actually be escaped.

The unsafe is for custom listeners where the editor-user can add html which should be executed as html in the reader-user's browser. But we don't have such listener built-in anyway.

---

I'd be comfortable about merging this.

[codeclimate]

Code Climate has analyzed commit 4f3834c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.0% (0.0% change).

View more on Code Climate.