Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#153 & #139 - make event optional in onCommit and return array from getSelectedCells #154

Merged
merged 1 commit into from May 6, 2019
Merged

#153 & #139 - make event optional in onCommit and return array from getSelectedCells #154

merged 1 commit into from May 6, 2019

Conversation

shawnmitchell
Copy link
Contributor

#139 - getSelectedCells should return an array
#153 - event parameter should be optional in onCommit

@shawnmitchell
#153 - make event optional in onCommit
c2c94e0 
#139 - getSelectedCells should return an array
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.676% when pulling c2c94e0 on shawnmitchell:typescript_onCommit_and_getSelectedCells_fixes into 963887e on nadbm:master.

@nadbm
Copy link
Owner

nadbm commented May 1, 2019

Perfect thank you @shawnmitchell

@shawnmitchell
Copy link
Contributor Author

My pleasure, @nadbm. Thanks for the library!

@shawnmitchell
Copy link
Contributor Author

@nadbm any idea when this might be merged?

@nadbm nadbm merged commit 45c5f36 into nadbm:master May 6, 2019
@shawnmitchell shawnmitchell deleted the typescript_onCommit_and_getSelectedCells_fixes branch May 6, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shawnmitchell @coveralls @nadbm