Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automatic adjustment of "README.md" #25

Closed
elfring opened this issue Oct 28, 2014 · 2 comments
Closed

Improve automatic adjustment of "README.md" #25

elfring opened this issue Oct 28, 2014 · 2 comments

Comments

@elfring
Copy link

elfring commented Oct 28, 2014

Some commands are used to update the file "README.md".

  • How do you think about to work with another template file? Would it eventually be better and safer to reuse the CMake functionality "configure_file"?
  • If you insist on in-place modification here, I suggest to drop the variable "MODIFIED_FILE_CONTENT" because of the detail that a direct use of the variable "FILE_CONTENT" would be sufficient there, wouldn't it?
@naelstrof
Copy link
Owner

Instead I decided on a shell script, giving me more flexibility and readability on how the README.md is updated.

I also made it a custom target, so that it's only executed when asked and properly keeps track of dependencies: https://github.com/naelstrof/maim/blob/master/CMakeLists.txt#L65

I believe this is pretty safe, and clean. Feel free to re-open if you feel otherwise.

@elfring
Copy link
Author

elfring commented Nov 18, 2014

Can it be that this shell script is not as portable and efficient as an approach where you would stick to the CMake programming language in the corresponding build scripts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants