Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--windowid produces odd results #53

Closed
eigengrau opened this issue Sep 10, 2015 · 12 comments
Closed

--windowid produces odd results #53

eigengrau opened this issue Sep 10, 2015 · 12 comments

Comments

@eigengrau
Copy link

When using --windowid instead of specifying the geometry manually, maim seems to not take the position of the specified window into account. The resulting images are partially cut-off and filled with transparency.

@eigengrau
Copy link
Author

This is an example.

Note that the second screenshot contains transparency to the right and bottom of the selected window.

@naelstrof
Copy link
Owner

It's expecting the x, y, w, and h of the window to be supplied as well. Glad you reported this it's not intended behavior.

I'll fix it when I can.

@naelstrof
Copy link
Owner

Should be fixed with 84eb647. Close when you confirm it's fixed.

@eigengrau
Copy link
Author

Works well on 84eb647, thanks!

@Ziusudra
Copy link

Ziusudra commented Feb 4, 2016

Hi, naelstrof

I ran across this problem and see it's fixed. Could you please tag a release so the fix get pushed downstream?

And thanks for the excellent software.

@naelstrof
Copy link
Owner

A release is tagged, 3.4.46 is the tag associated with this "fix", and the Arch team appear to have taken it in.

I'll take a look at the PKGBUILD they've made for maim, but you should check if the problem persists with the latest git release (AUR has maim-git). If it does I'll re-open this issue.

@Ziusudra
Copy link

Ziusudra commented Feb 4, 2016

Sorry, I somehow got it in my head that the fix commit after the last release.

I'll check with the AUR package.

@Ziusudra
Copy link

Ziusudra commented Feb 4, 2016

OK, also happens with maim-git.

pacman -Qs maim says local/maim-git v3.4.46.r2.g2cef0a3-1 and two lines added to im.cpp are there.

I'm probably reading this wrong and it's not the same bug.

result of maim ~/Pictures/$(date +%F-%T).png : http://imgur.com/jymdIZ0

result of maim -i $(xdotool getactivewindow) ~/Pictures/$(date +%F-%T).png : http://imgur.com/ZZjPekL

There is nothing on stderr or stdout when run from terminal.

@naelstrof
Copy link
Owner

Could you get me the output of xwininfo, xprop, and slop of that window?
Does running these two scripts and clicking on the offending window produce the same results?

#!/bin/bash
eval $(slop)
maim -i ${ID}
#!/bin/bash
eval $(slop)
maim -i ${ID} -g ${G}

I'll have to look into what's wrong, but if you gave me this information it would really help, thanks!

@naelstrof naelstrof reopened this Feb 4, 2016
@Ziusudra
Copy link

Ziusudra commented Feb 4, 2016

Pastebin: http://pastebin.com/kGcKEUqM

Both scripts produce this: http://imgur.com/1JkK7b6

@naelstrof
Copy link
Owner

Should be fixed with afc2724.

@Ziusudra
Copy link

Ziusudra commented Feb 5, 2016

Confirmed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants