Duplicate route names caused error on route caching

[yohanesgultom]

Issue description

Duplicate route names caused error on route caching

silsilah/routes/web.php

Lines 19 to 20 in 01524cd

	Route::get('password/change', 'Auth\ChangePasswordController@show')->name('password.change');
	Route::post('password/change', 'Auth\ChangePasswordController@update')->name('password.change');

Steps to reproduce the issue

1. Setup new instance from master branch
2. Run command php artisan route:cache

What's the expected result?

Command successful without any error

What's the actual result?

Command failed with error below:

Command failed with error `Unable to prepare route [password/change] for serialization. Another route has already been assigned name [password.change].`

Additional details / screenshot

This can be easily fixed by renaming one of the route. But to ensure consistent naming convention, I think it's best left to the original author

[nafiesl]

Hello, @yohanesgultom thanks for reporting.

I can reproduce the issue from my localhost.

$ php artisan route:cache
Route cache cleared!

In AbstractRouteCollection.php line 217:
                                                                                                                                
  Unable to prepare route [password/change] for serialization. Another route has already been assigned name [password.change].

Root cause:
As mentioned above, the route names are identical.

Workaround:

• Need to change the named route for changing the password
• Update all references to this route name (controller and views).

I will work on it, this should be quick. Thanks, @yohanesgultom.

[nafiesl]

Hi, @yohanesgultom this commit should fix the issue 8afb010. You can now try to pull the latest changes on the master branch, then try to run the route:cache command again.

We can expect this result on the terminal:

$ php artisan route:cache
Route cache cleared!
Routes cached successfully!

Thanks.

[yohanesgultom]

@nafiesl it's working now. Thanks!