Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 3120 and update self-signed.pythontest.net. #113

Merged
merged 5 commits into from Aug 31, 2019

Conversation

luk3yx
Copy link
Contributor

@luk3yx luk3yx commented Jun 9, 2019

Implements PEP 3120, mostly copied from 447d33e.

This may introduce backwards incompatibilities if eval("u'\xc2\xa3'") is expected to return u'\xc2\xa3' and not u'\xa3'.

luk3yx and others added 3 commits June 9, 2019 17:03
We updated the server, our testsuite must match.


https://bugs.python.org/issue36816


✈️ CLE -> DEN ✈️ #pycon2019
@luk3yx luk3yx changed the title Implement PEP 3120. Implement PEP 3120 and update self-signed.pythontest.net. Jun 9, 2019
@graingert
Copy link

I don't think this is a good idea on tauthon, which is focussed on making not breaking changes from py2.7.16.

If someone wants to use utf8 source files they can use the encoding marker comment

@stefantalpalaru
Copy link
Collaborator

I don't think this would break existing Python2 code, but it needs to pass the CI tests.

@graingert
Copy link

Woops I was under the impression that py2 source was latin-1 by default.

The default encoding was set to "ascii" in version 2.5.

@stefantalpalaru stefantalpalaru merged commit 717cb52 into naftaliharris:master Aug 31, 2019
@stefantalpalaru
Copy link
Collaborator

Thank you and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants