use nes.css from my fork #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
インシデント
本番環境でビルド時にwarningが発生する。
厳密にはscssのビルドでwarningが発生し、独自に設定したscss部分がビルドされずスタイルが適用されない。(scssのビルドが途中で止まっていると予想)
local環境で
ng serveしたときは発生しないが、ng serve --prodとすると発生する。対応
forkしたリポジトリでエラー箇所を削除し、それを
package.jsonに指定した。nagamoto/NES.css@4976eb8
理由
VSCodeでエラー箇所をチェックしていると↑の通りサジェストされ、その通りに変更(削除)するとwarningがなくなったため。
もともと何故warningになっていたのか、変更による他の箇所へ影響はないのかなどはscssのスキルが低いためわかっていない