Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldown callback #21

Closed
dave-killough opened this issue Dec 26, 2016 · 8 comments
Closed

Drilldown callback #21

dave-killough opened this issue Dec 26, 2016 · 8 comments

Comments

@dave-killough
Copy link

Great job! Nicolas just added drilldown support to his built-in table. Would you be willing to add this feature to subtotal as well? Thanks.

@nagarajanchinnasamy
Copy link
Owner

Thanks for your feedback. Could you please point me to an example to understand how this works.

@dave-killough
Copy link
Author

Here's the example Nicolas provided on his site. Just click on any value to trigger the callback that would handle the drilldown. I believe he checked in the handler around 12/25.

http://nicolas.kruchten.com/pivottable/examples/mps_prepop.html

@dave-killough
Copy link
Author

Here's some background:
http://github.com/nicolaskruchten/pivottable/issues/33

@nagarajanchinnasamy
Copy link
Owner

Thanks. Just thinking if we should treat the click event on a sub-total cell different from a value cell? Any thoughts?

@dave-killough
Copy link
Author

I think they should be treated the same way, passing in the filters behind the selected cell. They're all subtotals to me. That's why I like the drill-down.

@nagarajanchinnasamy
Copy link
Owner

@dave-killough I have committed the feature to master branch.

The syntax is slightly different from the original PivotTable.js package. Added an example of event handling to examples/260_event_handlers.html. Let me know if you have any thoughts on this.

Please check and provide your feedback.

nagarajanchinnasamy added a commit that referenced this issue Jan 2, 2017
@nagarajanchinnasamy
Copy link
Owner

Feature released. Closing the issue. Please report as a new issue if any...

@dave-killough
Copy link
Author

dave-killough commented Jan 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants