Encode Task ID and Summary in EDITOR tempfile #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontlaugh
force-pushed
the
encode_name
branch
2 times, most recently
from
2080f47
to
cf0531b
Compare
|
A screenshot of the encoded summary and task id |
|
I think we should run the task name through a whitelist filter and drop any characters not on the list. Also, convert spaces to dashes, and normalise to lowercase. Numbers and a-z should bring enough information over. |
dontlaugh
force-pushed
the
encode_name
branch
2 times, most recently
from
8f2576c
to
9c532d4
Compare
|
@naggie Ready for review! |
Introduce a new utility function (and unit test) for generated truncated filenames from task ID and summary. For now we limit our input to valid utf-8 alphanumerics only a single byte wide. Fixes naggie#117
dontlaugh
force-pushed
the
encode_name
branch
from
9c532d4
to
7de57d8
Compare
|
Thanks @dontlaugh. Nitpicking --- but if we filter characters that aren't in the whitelist we don't end up with repeated dashes; would you mind changing it so we don't get repeated dashes please? |
|
@naggie Fixed, I think. I've updated the test cases. Take a look at those to see the current behavior. |
|
Thanks @dontlaugh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new utility function (and unit test) for generated truncated
filenames from task ID and summary.
Go strings are UTF-8, and there may be pathological inputs that we need
to sanitize. Add these to the unit test and handle them as we find them.
Fixes #117