Use 3306 instead of MYSQL_PORT in the check_mysql plugins #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MYSQL_PORT constant used to be defined in mysql.h, and was used as the default port in the two plugins check_mysql and check_mysql_query. Now that mysql.h no longer defines that constant, our plugins fail to build against newer versions of MySQL and MariaDB. Since MYSQL_PORT used the "default port" on the local system, it actually was not the best choice as the default for the check plugins: when monitoring remote MySQL servers, the usual default of 3306 is more likely to be correct than whatever the local server happens to be listening on. As a result, we fix the issue by defining our own constant, called CHECK_PORT_DEFAULT, as "3306" at the top of both check_mysql.c and check_mysql_query.c. The existing uses of MYSQL_PORT have been changed to use the new CHECK_PORT_DEFAULT. This change is backwards-incompatible: any users who compiled in a MYSQL_PORT other than 3306 and who were running their checks on the same server as the database will now need to specify that port explicitly. Closes: #288
|
I believe this was fixed in #340 Can you verify? |
|
I think it's a tiny bit simpler to use a different constant name (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation with newer versions MySQL/MariaDB that don't define
MYSQL_PORT. The individual commit message explains.