Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restore Session#open signature for webmock compat
TODO: create PR for webmock's httpclient adapter to use get_session instead of open so that we can remove duplicated Site creation for each session.
- Loading branch information
Hiroshi Nakamura
committed
Nov 4, 2014
1 parent
c44dcc4
commit 1cba7bf
Showing
1 changed file
with
26 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cba7bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL I just merged this one bblimke/webmock#430 :) //cc @godfat
1cba7bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove @godfat patch in that case. @godfat thank you anyway :)
1cba7bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! :D
I hesitated to write it that way because it's really ugly,
but I really wanted to make it work immediately.
Now I just need to update httpclient again :)
Thanks for both of you.
1cba7bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@godfat My fault that I didn't run webmock spec. Thank YOU.