Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL scheme should throw an exception #294

Open
shaicoleman opened this issue Feb 3, 2016 · 0 comments
Open

Invalid URL scheme should throw an exception #294

shaicoleman opened this issue Feb 3, 2016 · 0 comments

Comments

@shaicoleman
Copy link

HTTPClient doesn't handle properly invalid schemes, and instead of throwing an exception it takes a long time until it timeouts instead.

HTTPClient.new.get('zzz://test.com')
HTTPClient::ConnectTimeoutError: execution expired

A better way to handle, would be to throw an exception, like when the scheme is missing, e.g.
HTTPClient.new.get('//test.com')
ArgumentError: Request URI must have schema. Possibly add 'http://' to the request URI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant