Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API server parameters to example udpt.conf file #38

Merged
merged 10 commits into from
Mar 21, 2018
Merged

Add API server parameters to example udpt.conf file #38

merged 10 commits into from
Mar 21, 2018

Conversation

pataquets
Copy link
Contributor

@pataquets pataquets commented Nov 2, 2017

Just wondering about the implications of making the previously only udpt.conf file better suited to local development, but especially Docker dev.
Is the file is intended to be used straight in a production server? If so, I understand that safe defaults should be provided, and logs go to file. Anyway, if the provided conf file is meant to quickly start developing, a mostly convenient (not necessarily safe) config should be put:

  • Enabling API server.
  • (optional) API listens on 0.0.0.0.
  • Logging to stdout/stderr.
  • Increase logging to info, at the least.

Whatever the purpose, be it is start developing quickly or server as production config, some warning comments in the file would be desirable.
I would like to get rid to .docker.conf version, if possible to avoid duplicity and getting out of sync.
Also, since the Docker image provides no config at /etc/ (it's unopinionated), you can build derived/child images suitable for both environments.

What do you think?

@pataquets
Copy link
Contributor Author

@naim94a Any comments/feedback on this? TIA.

@naim94a
Copy link
Owner

naim94a commented Mar 20, 2018

Sorry of the long delay,
I think that udpt should start with a hardened configuration - For me, security is always a priority.
If users would like to develop for/with, they should know how to configure udpt.

@naim94a naim94a closed this Mar 20, 2018
@pataquets
Copy link
Contributor Author

Sounds eminently reasonable, @naim94a.
However, since the original PR just adds to sample config entries, keeping the 'secure by default' approach, I wonder why the proposed changes haven't been merged.
Notice that the PR just adds the example entries (also listening only on localhost) without enabling API server. The more open configuration was proposed as a side discussion topic, but not in the PR. Sorry if I mixed two separate issues.

@naim94a naim94a reopened this Mar 21, 2018
@naim94a naim94a merged commit 309094b into naim94a:master Mar 21, 2018
naim94a pushed a commit that referenced this pull request Mar 21, 2018
Added API server parameters to example udpt.conf file (using default values)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants