-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API server parameters to example udpt.conf file #38
Conversation
Conflicts: docker-compose.yml
@naim94a Any comments/feedback on this? TIA. |
Sorry of the long delay, |
Sounds eminently reasonable, @naim94a. |
Added API server parameters to example udpt.conf file (using default values)
Just wondering about the implications of making the previously only
udpt.conf
file better suited to local development, but especially Docker dev.Is the file is intended to be used straight in a production server? If so, I understand that safe defaults should be provided, and logs go to file. Anyway, if the provided conf file is meant to quickly start developing, a mostly convenient (not necessarily safe) config should be put:
Whatever the purpose, be it is start developing quickly or server as production config, some warning comments in the file would be desirable.
I would like to get rid to
.docker.conf
version, if possible to avoid duplicity and getting out of sync.Also, since the Docker image provides no config at
/etc/
(it's unopinionated), you can build derived/child images suitable for both environments.What do you think?