fix all eslint error

.eslintignore

@@ -5,3 +5,6 @@ dist
 .eslintrc.js
 server
 *.js
+out
+**/types/**/*
+!tests

.vscode/settings.json

@@ -1,5 +1,6 @@
 {
   "javascript.preferences.importModuleSpecifier": "relative",
   "typescript.preferences.importModuleSpecifier": "relative",
-  "yarn.enableTouchbar": true
+  "eslint.alwaysShowStatus": true,
+  "eslint.lintTask.enable": true
 }

.vscode/tasks.json

@@ -0,0 +1,30 @@
+{
+  // See https://go.microsoft.com/fwlink/?LinkId=733558
+  // for the documentation about the tasks.json format
+  "version": "2.0.0",
+  "tasks": [
+    {
+      "label": "eslint project",
+      "type": "npm",
+      "script": "eslint",
+      "problemMatcher": [
+        {
+          "owner": "eslint",
+          "fileLocation": ["relative", "${workspaceFolder}"],
+          "pattern": {
+            "regexp": "^(.+):\\s(.+)\\((.+)\\)\\sat\\s(.+):(\\d+):(\\d+):$",
+            "severity": 1,
+            "message": 2,
+            "code": 3,
+            "file": 4,
+            "line": 5,
+            "column": 6
+          }
+        }
+      ],
+      "options": {
+        "cwd": "${workspaceFolder}"
+      }
+    }
+  ]
+}

global.d.ts

@@ -1,27 +1,36 @@
+import { Mondrian } from "mondrian/lib/mondrian";
 declare module "*.svg" {
   const value: string;
-
   export default value;
 }
 declare module "*.jpg" {
   const value: string;
-
   export default value;
 }
 
 declare module "*.png" {
-  const value: any;
+  const value: string;
   export default value;
 }
 
 declare module "*.frag" {
   const value: string;
-
   export default value;
 }
 
 declare module "*.vert" {
   const value: string;
-
   export default value;
 }
+
+declare global {
+  interface Window {
+    mo: Mondrian;
+    moApp: {
+      mo: Mondrian;
+      [key: string]: unknown;
+    };
+  }
+}
+
+export {};

packages/mondrian/src/container-manager.ts

@@ -8,7 +8,7 @@ export class MondrianContainerManager extends MondrianModuleBase {
    */
   private _$container: HTMLElement;
 
-  private _$panel: HTMLDivElement | undefined;
+  private _$panel?: HTMLDivElement;
 
   constructor(private shared: MondrianShared) {
     super();
@@ -76,10 +76,16 @@ export class MondrianContainerManager extends MondrianModuleBase {
   }
 
   hidePannel() {
-    this._$panel!.style.visibility = "hidden";
+    if (!this._$panel) {
+      return;
+    }
+    this._$panel.style.visibility = "hidden";
   }
 
   showPannel() {
-    this._$panel!.style.visibility = "visible";
+    if (!this._$panel) {
+      return;
+    }
+    this._$panel.style.visibility = "visible";
   }
 }

packages/mondrian/src/data-manager/data-manager.ts

@@ -72,7 +72,10 @@ export class MondrianDataManager extends MondrianModuleBase {
   }
 
   async startRead() {
-    this.reader = this.downStream!.getReader();
+    if (!this.downStream) {
+      throw new Error("downStream is not initialized");
+    }
+    this.reader = this.downStream.getReader();
     // eslint-disable-next-line no-constant-condition
     while (true) {
       const { done, value } = await this.reader.read();
@@ -83,7 +86,10 @@ export class MondrianDataManager extends MondrianModuleBase {
   }
 
   async startWrite() {
-    this.writer = this.upStream!.getWriter();
+    if (!this.upStream) {
+      throw new Error("upStream is not initialized");
+    }
+    this.writer = this.upStream.getWriter();
   }
 
   private delayTime = 300;
@@ -114,7 +120,10 @@ export class MondrianDataManager extends MondrianModuleBase {
   }
 
   async push(datas: IMondrianData[]) {
-    await this.writer!.write(datas);
+    if (!this.writer) {
+      throw new Error("writer is not initialized");
+    }
+    await this.writer.write(datas);
   }
 
   static EVENT_RECOVER_CONSUMED = "recover:consumed";

packages/mondrian/src/data-manager/data.ts

@@ -46,7 +46,7 @@ export interface IMondrianInteractData extends IMondrianCommonData {
 
 export interface IMondrianState {
   player: IMondrianPlayerState;
-  [key: string]: any;
+  [key: string]: string | number | boolean | object;
 }
 
 export interface IMondrianStateData extends IMondrianCommonData {
@@ -58,7 +58,7 @@ export interface IMondrianActionData extends IMondrianCommonData {
   type: MondrianDataType.COMMAND;
   data: {
     subType: MondrianActionType;
-    [key: string]: any;
+    [key: string]: string | number | boolean | object;
   };
 }
 

packages/mondrian/src/mondrian.ts

@@ -85,8 +85,7 @@ export class Mondrian extends MondrianModuleBase {
       this.start();
     }
 
-    // todo debug only
-    (window as any).mo = this;
+    window.mo = this;
   }
 
   override async start() {

packages/mondrian/src/player/player-manager.ts

@@ -78,7 +78,8 @@ export class MondrianPlayerManager extends MondrianModuleBase {
     this.consumers.set(consumerId, consumer);
   }
 
-  getConsumerByID(id: string) {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  getConsumerByID(_id: string) {
     console.warn("to be implemented");
   }
 

packages/mondrian/src/player/producer.ts

@@ -1,4 +1,3 @@
-import { Application, Container } from "pixi.js";
 import { MondrianShared } from "../shared";
 import {
   IMondrianInteractor,
@@ -12,7 +11,7 @@ import {
   MondrianActionType,
   IMondrianState,
 } from "../data-manager";
-import { MondrianPlayer, IMondrianPlayerState } from "./player";
+import { MondrianPlayer } from "./player";
 import { MondrianRenderer } from "../renderer/renderer";
 
 export class MondrianProducer
@@ -65,7 +64,8 @@ export class MondrianProducer
     ]);
   }
 
-  onUndo(event: any): void {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  onUndo(_event: unknown): void {
     this.dataManager.push([
       {
         playerID: this.id,
@@ -75,7 +75,8 @@ export class MondrianProducer
     ]);
   }
 
-  onRedo(event: any): void {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  onRedo(_event: unknown): void {
     this.dataManager.push([
       {
         playerID: this.id,
@@ -85,7 +86,8 @@ export class MondrianProducer
     ]);
   }
 
-  onClear(event: any): void {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  onClear(_event: unknown): void {
     this.dataManager.push([
       {
         playerID: this.id,
@@ -129,11 +131,13 @@ export class MondrianProducer
     }
   }
 
-  onClick(event: any): void {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  onClick(_event: unknown): void {
     console.log("implement it");
   }
 
-  onInput(event: any): void {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  onInput(_event: unknown): void {
     console.log("implement it");
   }
 

packages/mondrian/src/plugin/brush-plugin.ts

@@ -1,4 +1,8 @@
-import { IMondrianData, IMondrianStateData } from "../data-manager";
+import {
+  IMondrianData,
+  IMondrianInteractData,
+  IMondrianStateData,
+} from "../data-manager";
 import { MondrianPlugin, PluginType } from "./plugin";
 
 import { ILineStyleOptions, LINE_CAP, LINE_JOIN } from "@pixi/graphics";
@@ -106,7 +110,7 @@ export class BrushPlugin extends MondrianPlugin {
     return true;
   }
 
-  override reactDragStart(data: IMondrianData): boolean {
+  override reactDragStart(data: IMondrianInteractData): boolean {
     // todo if we should handle isDrawing === ture here?
     const p = { x: data.data.x, y: data.data.y };
     this.isDrawing = true;
@@ -116,14 +120,15 @@ export class BrushPlugin extends MondrianPlugin {
     return true;
   }
 
-  override reactDragMove(data: IMondrianData): boolean {
+  override reactDragMove(data: IMondrianInteractData): boolean {
     if (!this.isDrawing) return false;
     const p = { x: data.data.x, y: data.data.y };
     this.currentPos = { ...p };
     return true;
   }
 
-  override reactDragEnd(data: IMondrianData): boolean {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  override reactDragEnd(_data: IMondrianInteractData): boolean {
     if (!this.isDrawing) return false;
     this.isDrawing = false;
     this.handler.stop();

packages/mondrian/src/plugin/circle-plugin.ts

@@ -1,10 +1,8 @@
-import { MondrianUtils } from "../common/utils";
 import {
   IMondrianData,
   IMondrianStateData,
   MondrianDataType,
 } from "../data-manager";
-import { MondrianShared } from "../shared";
 import { BrushName } from "./brush-plugin";
 import { PluginType } from "./plugin";
 import { ShapePlugin } from "./shape-plugin";
@@ -14,10 +12,7 @@ export class CirclePlugin extends ShapePlugin {
 
   static override PID = Symbol("circle-plugin");
 
-  static override predicate(
-    data: IMondrianData | null,
-    shared?: MondrianShared
-  ): boolean {
+  static override predicate(data: IMondrianData | null): boolean {
     if (data === null) return false;
     if (data.type === MondrianDataType.SET_STATE) {
       if (data as IMondrianStateData) {

packages/mondrian/src/plugin/clear-plugin.ts

@@ -1,19 +1,14 @@
 import { BLEND_MODES } from "@pixi/constants";
 import { IMondrianData } from "../data-manager";
 import { MondrianGraphicsHandler } from "../renderer/grapichs-handler";
-import { MondrianRenderer } from "../renderer/renderer";
-import { MondrianShared } from "../shared";
 import { MondrianPlugin, PluginType } from "./plugin";
 
 export class ClearPlugin extends MondrianPlugin {
   static Type = PluginType.Global;
 
   static override PID = Symbol("clear-plugin");
 
-  static override predicate(
-    data: IMondrianData | null,
-    shared?: MondrianShared
-  ): boolean {
+  static override predicate(data: IMondrianData | null): boolean {
     if (data === null) {
       return true;
     }
@@ -24,7 +19,7 @@ export class ClearPlugin extends MondrianPlugin {
 
   // todo do have racing issue in this kind of command
   // todo don't react continuous clear command
-  override reactClear(event: any): boolean {
+  override reactClear(): boolean {
     this.handler = this.renderer.startGraphicsHandler();
     this.handler.config({
       enableDiscrete: false,

packages/mondrian/src/plugin/cursor-plugin.ts

@@ -1,4 +1,4 @@
-import { IMondrianData } from "../data-manager";
+import { IMondrianData, IMondrianInteractData } from "../data-manager";
 import { MondrianRenderer } from "../renderer/renderer";
 import { Sprite, Texture } from "pixi.js";
 import { MondrianPlugin, PluginType } from "./plugin";
@@ -61,7 +61,7 @@ export class CursorPlugin extends MondrianPlugin {
     this.triggerHideWhenIdle();
   }
 
-  override reactDragMove(data: IMondrianData): boolean {
+  override reactDragMove(data: IMondrianInteractData): boolean {
     this.cursor.visible = true;
     this.cursor.x = data.data.x;
     this.cursor.y = data.data.y - this.cursor.height;
@@ -83,15 +83,17 @@ export class CursorPlugin extends MondrianPlugin {
     }, 1000);
   }
 
-  override reactKeyDown(data: IMondrianData) {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  override reactKeyDown(_data: IMondrianInteractData) {
     if (this.shared.settings.viewport) {
       this.cursor.texture = this.cursorDargTexture;
       return true;
     }
     return false;
   }
 
-  override reactKeyUp(data: IMondrianData) {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  override reactKeyUp(_data: IMondrianInteractData) {
     if (this.shared.settings.viewport) {
       this.cursor.texture = this.cursorDrawTexture;
       return true;

packages/mondrian/src/plugin/eraser-plugin.ts

@@ -4,7 +4,6 @@ import {
   IMondrianStateData,
   MondrianDataType,
 } from "../data-manager";
-import { MondrianShared } from "../shared";
 import { BrushName } from "./brush-plugin";
 import { PencilBrushPlugin } from "./pencil-plugin";
 import { PluginType } from "./plugin";
@@ -14,10 +13,7 @@ export class EraserBrushPlugin extends PencilBrushPlugin {
 
   static override PID = Symbol("eraser-plugin");
 
-  static override predicate(
-    data: IMondrianData | null,
-    shared?: MondrianShared
-  ): boolean {
+  static override predicate(data: IMondrianData | null): boolean {
     if (data === null) return false;
     if (data.type === MondrianDataType.SET_STATE) {
       if (data as IMondrianStateData) {