Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forceRedirect from payload #280

Closed
wants to merge 1 commit into from
Closed

forceRedirect from payload #280

wants to merge 1 commit into from

Conversation

qwerin
Copy link

@qwerin qwerin commented Mar 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #280 (130ce99) into master (b31de8d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files          11       11           
  Lines         360      360           
  Branches      104      104           
=======================================
  Hits          307      307           
  Misses         20       20           
  Partials       33       33           
Impacted Files Coverage Δ
src/Naja.ts 97.50% <ø> (ø)
src/core/RedirectHandler.ts 69.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31de8d...130ce99. Read the comment docs.

@jiripudil
Copy link
Member

Hello, thank you for contributing to Naja! Unfortunately, this particular behaviour that you're adding has been deliberately removed in 2.0. Please refer to #26 and #47 for reasoning and discussion.

@jiripudil jiripudil closed this Mar 17, 2021
@qwerin
Copy link
Author

qwerin commented Mar 17, 2021

No nevím v mém use case kdy client chce udelat nejakou upravu a server mu vrati ze mu vyprsel logon session a musi se znovu prihlasit tzn. presmeruje na logon page. Takze bych musel mit na vsechny ajax dotazy mit force. Na to budu muset asi napsat extension. Tohle mi prislo fajn elegatni reseni ktere defakto nezasaguje moc do fuknci naji ale je asi v rozporu s politikou. Co uz.

@RichterL
Copy link

RichterL commented Apr 3, 2021

Teď to samé také řeším. Vyprší session přihlášení, nette redirectuje na Sign:in ale ten není ajaxový je úplně oddělený. Jak to řešit jinak než přes extension, která vrátí chování forceRedirectu? Neco jako disallowedOrigins by to mohlo řešit ne?

@emololftw
Copy link

Teď to samé také řeším. Vyprší session přihlášení, nette redirectuje na Sign:in ale ten není ajaxový je úplně oddělený. Jak to řešit jinak než přes extension, která vrátí chování forceRedirectu? Neco jako disallowedOrigins by to mohlo řešit ne?

já po uplynutí času volám rovnou: naja.redirectHandler.makeRedirect({link :Front:Auth:SignIn:}, true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants