Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot more metrics in real-time #2

Closed
1 of 5 tasks
nakabonne opened this issue Sep 15, 2020 · 6 comments
Closed
1 of 5 tasks

Plot more metrics in real-time #2

nakabonne opened this issue Sep 15, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@nakabonne
Copy link
Owner

nakabonne commented Sep 15, 2020

It would be nice if it's able to press Ctrl-i to switch between charts.

@brenol
Copy link
Contributor

brenol commented Oct 3, 2020

What do you think about we clicking on each option and showing them (changing the current line chart?)?

I wish we had tabs on termdash, but it doesn't have tabs unfortunately :(

@nakabonne
Copy link
Owner Author

@brenol Sorry, I completely missed your message. termdash is capable of switching dynamically the layouts like this.

@brenol
Copy link
Contributor

brenol commented Oct 10, 2020

@nakabonne no problem. I started work on percentiles and I think I'll be able to open a PR this weekend :)

@nakabonne
Copy link
Owner Author

That would help. I'm wondering if we can do that with Histogram which is commented out now.

// Histogram *vegeta.Histogram `json:"buckets,omitempty"`

@nakabonne nakabonne added the enhancement New feature or request label Oct 10, 2020
@brenol
Copy link
Contributor

brenol commented Oct 10, 2020

I'll take a look at histogram. However, vegeta.Metrics calculating quantiles is actually okay (??).

This is how it looks (wip) [p50, p75, p90, p95 & p99]. My test server is running Sleep(rand.Intn(1000 * Millisecond)):
image

I'm not done yet, as I want to show legend like in this issue mum4k/termdash#188

Just didn't get the time, but I'll finish this one soon and I'll try to make it as reusable as possible so we can support bytes in/bytes out & status codes as well.

nakabonne pushed a commit that referenced this issue Oct 18, 2020
@nakabonne
Copy link
Owner Author

Closing because I opened each issue individually; label:new-chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants