Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls config options #104

Merged
merged 2 commits into from
May 29, 2021
Merged

Conversation

boggyhole
Copy link
Contributor

@boggyhole boggyhole commented May 27, 2021

Allow mutual tls client configuration, adding root CAs and tls
verification

FIxes: #103

Allow mutual tls client configuration, adding root CAs and tls
verfication
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #104 (2196a39) into master (41ab260) will decrease coverage by 1.10%.
The diff coverage is 70.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   71.99%   70.90%   -1.09%     
==========================================
  Files           9        9              
  Lines         589      615      +26     
==========================================
+ Hits          424      436      +12     
- Misses        132      144      +12     
- Partials       33       35       +2     
Impacted Files Coverage Δ
main.go 71.60% <68.58%> (-3.40%) ⬇️
attacker/attacker.go 67.80% <83.34%> (+1.76%) ⬆️
gui/drawer.go 70.87% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ab260...2196a39. Read the comment docs.

Copy link
Owner

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. Thanks a lot!

@nakabonne nakabonne merged commit a195f49 into nakabonne:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add some tls options
3 participants