Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage layer to handle time-series data #105

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

nakabonne
Copy link
Owner

I just settled on stop sending results from the attacker to the drawer directly. From now all data points are inserted into a new storage layer and the drawer periodically queries to that storage.

The storage is backed by https://github.com/nakabonne/tstorage

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #105 (6b70223) into master (b651fdb) will decrease coverage by 7.97%.
The diff coverage is 33.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   71.55%   63.59%   -7.96%     
==========================================
  Files           9       11       +2     
  Lines         615      703      +88     
==========================================
+ Hits          440      447       +7     
- Misses        140      220      +80     
- Partials       35       36       +1     
Impacted Files Coverage Δ
gui/drawer.go 58.27% <0.00%> (-15.75%) ⬇️
gui/keybinds.go 51.62% <0.00%> (ø)
storage/storage.go 0.00% <0.00%> (ø)
main.go 67.92% <8.34%> (-3.67%) ⬇️
storage/fake_storage.go 50.00% <50.00%> (ø)
attacker/attacker.go 70.97% <77.56%> (+3.18%) ⬆️
gui/gui.go 73.74% <85.72%> (+0.83%) ⬆️
attacker/fake_attacker.go 100.00% <100.00%> (ø)
gui/widgets.go 60.98% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b651fdb...6b70223. Read the comment docs.

@nakabonne nakabonne merged commit e3f49a4 into master Jun 1, 2021
@nakabonne nakabonne deleted the add-tstorage branch June 1, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants