Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to draw the chart on a regular basis #77

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Conversation

nakabonne
Copy link
Owner

@nakabonne nakabonne commented Oct 19, 2020

Fixes: #75

Changes:

  • Rather than calling the termdash API on every attack, made sure to buffer the value.
  • Call the termdash API periodically (specified as redraw interval)

@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #77 into master will decrease coverage by 3.43%.
The diff coverage is 80.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   75.71%   72.28%   -3.42%     
==========================================
  Files           8        8              
  Lines         535      541       +6     
==========================================
- Hits          405      391      -14     
- Misses         99      120      +21     
+ Partials       31       30       -1     
Impacted Files Coverage Δ
attacker/metrics.go 100.00% <ø> (ø)
gui/keybinds.go 50.00% <0.00%> (-1.61%) ⬇️
gui/drawer.go 75.84% <82.86%> (-17.98%) ⬇️
attacker/attacker.go 68.63% <88.89%> (-2.38%) ⬇️
gui/gui.go 73.20% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f69f52...2d5916b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when running at high rate
2 participants