Fix Progress gauge to reach 100% #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
nakabonne
requested changes
Nov 18, 2020
|
@shubham14bajpai Thank you for your contribution! I've left some comments.
This is caused by entirely another problem with ali's drawing performance. If the ali is running at a high rate, the drawing may not be finished after the specified duration of time. This has been improved considerably, but there is still room for improvement. |
|
@nakabonne I have addressed review comments. PTAL. |
nakabonne
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
This PR fixes the stuck progress bar when the rate flag is more than the system capabilities.
The most accurate representation was on nanoseconds so time.Duration.