Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change kustomize bases to resources #292

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Sep 18, 2023

https://github.com/kubernetes-sigs/kustomize/blob/59696d1acec9213593e17048d4c468b4930799b4/api/types/kustomization.go#L133

	// Deprecated: Anything that would have been specified here should be specified in the Resources field instead.
	Bases []string `json:"bases,omitempty" yaml:"bases,omitempty"`

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #292 (22875c4) into main (efbd822) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   31.97%   31.97%           
=======================================
  Files           3        3           
  Lines         172      172           
=======================================
  Hits           55       55           
  Misses        116      116           
  Partials        1        1           

@nakamasato nakamasato marked this pull request as ready for review September 18, 2023 22:35
@nakamasato nakamasato merged commit 14aeabf into main Sep 18, 2023
8 checks passed
@nakamasato nakamasato deleted the change-kustomize-bases-to-resources branch September 18, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant