Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working anymore with Fastlane 2.86.0 #24

Closed
valeriomazzeo opened this issue Mar 20, 2018 · 7 comments
Closed

Not working anymore with Fastlane 2.86.0 #24

valeriomazzeo opened this issue Mar 20, 2018 · 7 comments

Comments

@valeriomazzeo
Copy link

keep getting this error:

[!] The exception involves the following plugins:
 -  danger-xcov
bundler: failed to load command: danger (/Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/bin/danger)
Danger::DSLError: 
[!] Invalid `Dangerfile` file: Could not find option 'xcconfig' in the list of available options: workspace, project, scheme, configuration, source_directory, derived_data_path, output_directory, html_report, markdown_report, json_report, minimum_coverage_percentage, slack_url, slack_channel, skip_slack, slack_username, slack_message, ignore_file_path, include_test_targets, exclude_targets, include_targets, only_project_targets, coveralls_service_name, coveralls_service_job_id, coveralls_repo_token
 #  from Dangerfile:25
 #  -------------------------------------------
 #  # code coverage
 >  xcov.report(
 #     scheme: "myproj-Package",
 #  -------------------------------------------
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/ui/interface.rb:133:in `user_error!'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in `method_missing'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/configuration/configuration.rb:327:in `verify_options_key!'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/configuration/configuration.rb:216:in `fetch'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/project.rb:312:in `xcodebuild_parameters'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/project.rb:328:in `build_xcodebuild_showbuildsettings_command'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/project.rb:348:in `build_settings'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/fastlane-2.86.0/fastlane_core/lib/fastlane_core/project.rb:385:in `default_build_settings'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/xcov-1.3.3/lib/xcov/manager.rb:145:in `derived_data_path'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/xcov-1.3.3/lib/xcov/manager.rb:40:in `parse_xccoverage'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-xcov-0.4.1/lib/danger_plugin.rb:64:in `produce_report'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-xcov-0.4.1/lib/danger_plugin.rb:36:in `report'
  Dangerfile:25:in `block in parse'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/danger_core/dangerfile.rb:200:in `eval'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/danger_core/dangerfile.rb:200:in `block in parse'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/danger_core/dangerfile.rb:196:in `instance_eval'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/danger_core/dangerfile.rb:196:in `parse'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/danger_core/dangerfile.rb:274:in `run'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/danger_core/executor.rb:28:in `run'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/lib/danger/commands/runner.rb:68:in `run'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/gems/danger-5.5.11/bin/danger:5:in `<top (required)>'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/bin/danger:23:in `load'
  /Users/travis/build/myproj/src/vendor/bundle/ruby/2.4.0/bin/danger:23:in `<top (required)>'
@nakiostudio
Copy link
Collaborator

Hi @valeriomazzeo 👋

Thanks for reporting. Can I see the parameters you're passing to xcov?

@valeriomazzeo
Copy link
Author

xcov.report(
   scheme: "MyProj-Package",
   minimum_coverage_percentage: 70.0,
   include_targets: "MyProj.framework"
)

@nakiostudio
Copy link
Collaborator

This change on Fastlane is causing many important issues. I recommend not updating Fastlane to 2.86.0 until we get confirmation everything is OK.

Linking fastlane/fastlane#12103 for reference.

@nakiostudio
Copy link
Collaborator

Also linking this fastlane/fastlane#12113 to keep track of the xcodeproj issues.

@joshdholtz
Copy link
Member

Hello! The xcodeproj issues just got merged (fastlane/fastlane#12147) so this should be fixed in next fastlane release 🙃

@nakiostudio
Copy link
Collaborator

Thanks for the update @joshdholtz 👍

@ashraf-patel
Copy link

What's the status on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants