Skip to content

Commit

Permalink
fixed offsetX issue in slider
Browse files Browse the repository at this point in the history
  • Loading branch information
nalbion committed Feb 3, 2015
1 parent 1d09299 commit 0afb6c4
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bower.json
@@ -1,6 +1,6 @@
{
"name": "angular-bootstrap-closure",
"version": "0.0.2",
"version": "0.0.3",

"author": "Nicholas Albion",
"description": "Bootstrap UI components for AngularJS apps using Closure Compiler, no jQuery dependencies",
Expand Down
4 changes: 3 additions & 1 deletion src/js/directives/slider.js
Expand Up @@ -3,6 +3,8 @@
*/
goog.provide('abc.sliderModule');

goog.require('abc.utils');

/**
* As per the <a href="https://developer.mozilla.org/en/docs/Web/HTML/Element/Input">HTML5 &lt;input type="range"></a>
* control, defaults to:
Expand Down Expand Up @@ -157,7 +159,7 @@ abc.SliderCtrl = function ($scope, $attrs, $window, $timeout) {

var value,
x = event.touches ? event.touches[0].clientX : event.clientX,
left = _sliderElement.offsetLeft,
left = abc.utils.offsetX(_sliderElement), //.offsetLeft,
_handleHalfWidth = _handle[0].offsetWidth / 2,
sliderWidth = _sliderElement.offsetWidth;

Expand Down
18 changes: 18 additions & 0 deletions src/js/utils.js
@@ -0,0 +1,18 @@
goog.provide('abc.utils');

/**
* @param {HTMLElement} element
* @returns {number} pixels from the left of the page
*/
abc.utils.offsetX = function (element) {
//try {return elm.offset();} catch(e) {}
//element = elmement[0];
var _x = 0;
//var _y = 0;
var body = document.documentElement || document.body;
var scrollX = window.pageXOffset || body.scrollLeft;
//var scrollY = window.pageYOffset || body.scrollTop;
return element.getBoundingClientRect().left + scrollX;
//_y = rawDom.getBoundingClientRect().top + scrollY;
//return { left: _x, top:_y };
};

0 comments on commit 0afb6c4

Please sign in to comment.