Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #197 #212

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Fix #197 #212

merged 2 commits into from
Dec 6, 2022

Conversation

nalepae
Copy link
Owner

@nalepae nalepae commented Nov 27, 2022

Fix ZeroDivisionError on Windows using Progress bars.

This error may happen only on Windows because - maybe - Windows clock is not as precise as Mac/Linux clocks.
2 successive calls to time_ns may return the same result, causing the ZeroDivisionError.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #212 (5169554) into master (5169554) will not change coverage.
The diff coverage is n/a.

❗ Current head 5169554 differs from pull request most recent head 93b8b67. Consider uploading reports for the commit 93b8b67 to get more accurate results

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files          12       12           
  Lines         579      579           
=======================================
  Hits          456      456           
  Misses        123      123           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nalepae nalepae requested a review from till-m November 27, 2022 23:45
Copy link
Collaborator

@till-m till-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pandas-version: "1.0.5"
# Pandas 1.1.5 has to be fully rebuilt with Python >= 3.10.5 (taking > 10 min)
- python-version: "3.10.5"
- python-version: "3.10.8"
pandas-version: "1.1.5"
# Pandas 1.2.5 has to be fully rebuilt with Python >= 3.10.5 (taking > 10 min)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these comments no longer accurate or do we just not care about building time?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum since there is inequality and not strict equality, I guess these comments are still valid.
Example:

# Pandas 1.1.5 has to be fully rebuilt with Python >= 3.10.5 (taking > 10 min)

Something which is valid for python >= 3.10.5 is also valid for python >= 3.10.8, mathematically speaking :)

@till-m
Copy link
Collaborator

till-m commented Dec 6, 2022

Unless there's any objections, I will go ahead with merging this.

@nalepae
Copy link
Owner Author

nalepae commented Dec 6, 2022

Actually I would really like to test it on Windows, but I did not take the time to do it properly.
(Did not achieve to run a Windows VM on my M1 Mac book).

Well, I tested it on mac and it works.
In worst case, it still does not work on Windows. (no improvement, no degradation)
In best case, it works on Windows. (improvement)

==> We can merge!

@nalepae nalepae merged commit 249dad5 into master Dec 6, 2022
@nalepae nalepae deleted the 197 branch December 6, 2022 15:35
@till-m till-m mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants