-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #197 #212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 12 12
Lines 579 579
=======================================
Hits 456 456
Misses 123 123 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…and protect against `ZeroDivisionError`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pandas-version: "1.0.5" | ||
# Pandas 1.1.5 has to be fully rebuilt with Python >= 3.10.5 (taking > 10 min) | ||
- python-version: "3.10.5" | ||
- python-version: "3.10.8" | ||
pandas-version: "1.1.5" | ||
# Pandas 1.2.5 has to be fully rebuilt with Python >= 3.10.5 (taking > 10 min) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these comments no longer accurate or do we just not care about building time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum since there is inequality and not strict equality, I guess these comments are still valid.
Example:
# Pandas 1.1.5 has to be fully rebuilt with Python >= 3.10.5 (taking > 10 min)
Something which is valid for python >= 3.10.5
is also valid for python >= 3.10.8
, mathematically speaking :)
Unless there's any objections, I will go ahead with merging this. |
Actually I would really like to test it on Windows, but I did not take the time to do it properly. Well, I tested it on mac and it works. ==> We can merge! |
Fix
ZeroDivisionError
on Windows using Progress bars.This error may happen only on Windows because - maybe - Windows clock is not as precise as Mac/Linux clocks.
2 successive calls to
time_ns
may return the same result, causing theZeroDivisionError
.