unwrap PopoverContent on macOS #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, a popover is displayed in its own `NSWindow`, and the `contentView` of that window is an `NSHostingView`. The hosted SwiftUI `View` structure looks like this:
```
ModifiedContent<AnyView, PopoverRootModifier>
AnyView
PopoverContent<ModifiedContent<ModifiedContent<ModifiedContent<YourPopoverContent, ClearNavigationContextModifier>, _EnvironmentKeyWritingModifier<NavigationEnabled>>, _EnvironmentKeyWritingModifier<Optional<NavigationState>>>>
ModifiedContent<ModifiedContent<ModifiedContent<YourPopoverContent, ClearNavigationContextModifier>, _EnvironmentKeyWritingModifier<NavigationEnabled>>, _EnvironmentKeyWritingModifier<Optional<NavigationState>>>
ModifiedContent<ModifiedContent<YourPopoverContent, ClearNavigationContextModifier>, _EnvironmentKeyWritingModifier<NavigationEnabled>>
ModifiedContent<YourPopoverContent, ClearNavigationContextModifier>
YourPopoverContent
```
This commit allows ViewInspector to unwrap PopoverContent so that it can inspect the user-provided views of the popover.
|
This is great! Thanks @mayoff ! |
nalexn
added a commit
that referenced
this pull request
May 2, 2023
nalexn
added
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, a popover is displayed in its own
NSWindow, and thecontentViewof that window is anNSHostingView. The hosted SwiftUIViewstructure looks like this:This commit allows ViewInspector to unwrap PopoverContent so that it can inspect the user-provided views of the popover.