Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated approach for momentum when hybrid meshes are in use is wrong #84

Closed
spdomin opened this issue Mar 7, 2017 · 3 comments
Closed
Assignees

Comments

@spdomin
Copy link
Contributor

spdomin commented Mar 7, 2017

I let this one slip... 'should have been more careful in the review.

Basically, the bug is that the consolidated approach logic is only hit when the first interior algorithm type is found. However, for a hybrid mesh, this does not work. The logic needs to be either consolidated or not. Then, for each part pushed in, the code needs to check the map for the topology if interest. The major complexity is added when element mass is added and in supporting both nodal source terms and the consolidated approach (which I would have preferred to hold off on).

Continuity hybrid looks fine.

@spdomin spdomin changed the title Consolidated approach for momentum is all wrong Consolidated approach for momentum when hybrid meshes are in use is wrong Mar 7, 2017
@sayerhs
Copy link
Contributor

sayerhs commented Mar 7, 2017

@spdomin I see that the way the if-conditions are set up, the new consolidated alg does not build additional SuppAlg instances for multiple topos. I have a potential fix for this in sayerhs/Nalu@84c74d973168dcaf . I think this should resolve the issue for both non-consolidated and consolidated Alg setups. Can you share your failing test case with me, so that I can test this and make additional fixes if necessary?

@spdomin
Copy link
Contributor Author

spdomin commented Mar 7, 2017

My failing test is the dgNonConformalThreeBlade test that includes bug fixes in ContMass and a newly converted NSO KE flavor. We need to find a test that uses hybrid with one of the suite of SuppAlgs converted. The cylinder in cross flow might be one, however, that probably is using edges.

@spdomin
Copy link
Contributor Author

spdomin commented Apr 24, 2017

This is closed...

@spdomin spdomin closed this as completed Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants