Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large file with .md5 extension isn't recognized as containing hashes #97

Closed
Anton-V-K opened this issue Nov 29, 2021 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@Anton-V-K
Copy link

Anton-V-K commented Nov 29, 2021

When double-clicking a file with .md5 extension , the app opens it and generates hashes for it (which is quite useless).
How to make the app verify the checksums instead?
I think, this should be a default action for files with extensions .md5/.sha1/etc.
The file was generated with ExactFile and has the content like:

; Checksums generated by ExactFile 1.0.0.15
; http://www.exactfile.com
; 29.11.2021 0:56:25

6ddac8c5ce38b6d929948a5e951cf234 *window_PNG17693.png
c8ddc6d5d28488fd91d8116a985047ff *Всемирный день ребёнка.docx
...
@namazso
Copy link
Owner

namazso commented Nov 29, 2021

could you please upload the file here? Encoding might make a difference, as this should be detected just fine.

@namazso namazso added the bug Something isn't working label Nov 29, 2021
@Anton-V-K
Copy link
Author

Anton-V-K commented Nov 29, 2021

Thanks for quick response.
Here is the full file checksums.md5.zip (~1.2 MB)

@namazso
Copy link
Owner

namazso commented Nov 29, 2021

Ah, it's the size, currently files over 1 MB are not checked for sumfile-ness as checking is rather expensive and happens early on. I guess i should make this into some sort of configurable option. Or just try to parse anything regardless of size and early-fail if something cannot be a valid sumfile, then only edge cases should cause performance problems like a file full of newlines or something.

@Anton-V-K Anton-V-K changed the title Opening file with .md5 extension should start hashes verification Large file with .md5 extension isn't recognized as containing hashes Nov 29, 2021
@namazso
Copy link
Owner

namazso commented Nov 30, 2021

Should be fixed in latest development build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants