Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency caches over HTTP for OPEN, BID, and UPDATE #26

Conversation

RevCBH
Copy link

@RevCBH RevCBH commented Aug 5, 2020

No description provided.

@RevCBH RevCBH requested a review from turbomaze August 5, 2020 18:32
lib/wallet/wallet.js Show resolved Hide resolved
lib/wallet/wallet.js Outdated Show resolved Hide resolved
lib/wallet/http.js Outdated Show resolved Hide resolved
lib/wallet/http.js Outdated Show resolved Hide resolved
lib/wallet/wallet.js Show resolved Hide resolved
test/wallet-test.js Outdated Show resolved Hide resolved
@RevCBH RevCBH force-pushed the bennetthoffman/ch2594/hsd-proxy-http-endpoint-for-sendbididempotent branch from 8d5b7e2 to 2adf870 Compare August 27, 2020 19:17
lib/wallet/rpc.js Outdated Show resolved Hide resolved
lib/wallet/wallet.js Outdated Show resolved Hide resolved
lib/wallet/http.js Outdated Show resolved Hide resolved
@RevCBH RevCBH requested a review from turbomaze August 27, 2020 21:00
Copy link

@turbomaze turbomaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm you've tested sending a bid/open/update with the latest version of this code? Ideally trying with both rpc and http APIs?

@RevCBH RevCBH force-pushed the bennetthoffman/ch2594/hsd-proxy-http-endpoint-for-sendbididempotent branch from e9348a6 to 5a4992d Compare August 28, 2020 16:55
@RevCBH
Copy link
Author

RevCBH commented Aug 29, 2020

Verified over rpc and http

@RevCBH RevCBH requested a review from turbomaze August 29, 2020 01:17
@turbomaze turbomaze merged commit 04c97e2 into production-namebase Aug 29, 2020
@turbomaze turbomaze deleted the bennetthoffman/ch2594/hsd-proxy-http-endpoint-for-sendbididempotent branch August 29, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants