forked from handshake-org/hsd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idempotency caches over HTTP for OPEN, BID, and UPDATE #26
Merged
turbomaze
merged 4 commits into
production-namebase
from
bennetthoffman/ch2594/hsd-proxy-http-endpoint-for-sendbididempotent
Aug 29, 2020
Merged
Idempotency caches over HTTP for OPEN, BID, and UPDATE #26
turbomaze
merged 4 commits into
production-namebase
from
bennetthoffman/ch2594/hsd-proxy-http-endpoint-for-sendbididempotent
Aug 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbomaze
suggested changes
Aug 27, 2020
8d5b7e2
to
2adf870
Compare
turbomaze
suggested changes
Aug 27, 2020
turbomaze
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm you've tested sending a bid/open/update with the latest version of this code? Ideally trying with both rpc and http APIs?
…xy-http-endpoint-for-sendbididempotent
e9348a6
to
5a4992d
Compare
Verified over rpc and http |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.