Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagated hsd PR 499 (https://github.com/handshake-org/hsd/pull/499)… #53

Closed
wants to merge 2 commits into from

Conversation

rozaydin
Copy link

@rozaydin rozaydin commented Mar 5, 2021

This branch directly copies everything from handshake-org#499
into namebase hsd.

Signed-off-by: rozaydin ridvan@namebase.io

Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Copy link

@turbomaze turbomaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase this on production-namebase instead of ridvan-rebase-hsd-3.2.0?

@rozaydin
Copy link
Author

Could you rebase this on production-namebase instead of ridvan-rebase-hsd-3.2.0?

I am closing this PR and creating a new one, rebasing took time and introduced more code churn, thus i have re-created PR on top of production-namebase, encountered failing tests, updated and fixed them. will move the discussion to new PR.

@rozaydin rozaydin closed this Mar 31, 2021
@nodech nodech deleted the ridvan-open-null-address-3 branch April 20, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants