-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ridvan non changing wallet #64
Conversation
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
Signed-off-by: rozaydin <ridvan@namebase.io>
This PR contains a new parameter for wallet creation Below sample code shows how new param is used:
One important thing to note is, to store state (in leveldb) we are now using the last bit of flags byte in Account object.
PR modifies the wallet-http endpoints for wallet and account creation to pass new parameter. When interacting with HTTP interface. |
Signed-off-by: rozaydin <ridvan@namebase.io>
lib/wallet/account.js
Outdated
let key; | ||
if (this.staticAddress) { | ||
// branch 1 -> changes | ||
key = this.getSpecificKey(0, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want the change addr to be static too, I'll push a commit to replace this with 0, 0 if there's nothing else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's already static and we have tests for it to verify. The parameter 1 on the getSpecificKey is for branch (1 -> changes)
am i missing sth ?
No description provided.