-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plumbing to the wallet plugin to accept configuration for primary wallet #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify -- by passing this config option to a wallet, if no primary wallet exists yet, then it will create one with the provided options? Can you document the shape of getWalletOptions?
@turbomaze It should be the standard options you pass anytime you create a wallet. https://sourcegraph.com/github.com/handshake-org/hsd/-/blob/lib/wallet/wallet.js#L91-152 It will only create the |
Can you explain this somewhere in the code since this custom option doesn't have an example in https://github.com/handshake-org/hsd/blob/master/etc/sample.conf (which is where the rest of the option examples live) @jacobhaven |
01708e9
to
37b5a96
Compare
37b5a96
to
49e0159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
49e0159
to
531e7f7
Compare
No description provided.