Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools backport #50

Closed
wants to merge 15 commits into from
Closed

Conversation

indolering
Copy link

Backport of Bitcoin's Autotools, fixes OS X build issues.

namecoin-qt and others added 15 commits December 17, 2013 18:13
- RemoveFromMemoryPool - fixed handling of pending names when reorganizing the block chain
- version-dependent arguments in UPNP_AddPortMapping (miniupnpc 1.5 vs 1.6)
Merge pull request namecoin-qt#14 from namecoinq/master
bitcoin repository.  Builds (without Qt) on Mac OSX.
Namecoin code hasn't been refactored to match the library modules.
namecoin-qt can't link against libnamecoin_common.a because of
circular references.  Put libnamecoin_common.a objects in
libnamecoinqt.  Don't build src/test if --with-qt.
@khalahan
Copy link
Member

khalahan commented Mar 3, 2014

Has somebody tested this pull request ?

@indolering
Copy link
Author

I've only had minor troubles on OS X but got it working for the non GUI. This is owning largely to my stupid configs, OS X's lack of a coherent dependency management system, and my not caring enough to test the GUI component : P

I cannot speak for other architectures. I would ask on IRC.

@indolering
Copy link
Author

I will try building the GUI version on the OS X dev machine tonight. If you can get it to build on Linux, we are good to go.

@indolering
Copy link
Author

Alright, I thought my build troubles earlier were my own fault, but I cannot get this to build even on a fresh dev machine. Gist with log here: https://gist.github.com/nmcbot/9403870

Happy to give anyone who wants to try remote access to my machine.

@phelixbtc
Copy link
Contributor

Is this obsolete? Looks overly complicated.

@JeremyRand
Copy link
Member

@phelixbtc Last I heard OS X building was still messed up in the main repo, which this PR is supposed to fix. So it's still relevant, but I'm not sure if @indolering had any luck verifying that this PR works.

@indolering
Copy link
Author

I can get it to built the non-qt version which is a major improvement. Others can get this to build on Linux and Windows then I would support accepting the pull request.

@indolering
Copy link
Author

Figured out what's wrong with 10.9, just linking these here for future reference:

bitcoin/bitcoin#2806
bitcoin/bitcoin#3228
bitcoin/bitcoin#3291

@phelixbtc Are you able to get this to build on Windows? Can someone with a local Ubuntu install try it out?

@phelixbtc
Copy link
Contributor

Autotools on windows is somewhat inconvenient to install so I'd rather not try but stick to easywinbuilder which is a piece of cake.

@indolering
Copy link
Author

If we are basing on Libcoin, this just doesn't make any sense. I really want to get it building on my own machine so we can have an official binary but now there is some sort of issue with 10.9. I will try one more time on my older machine using 10.8.

Anyway, @domob1812, I'm voting to reject this pull request, I can maintain my own fork and provide binaries from that until the Libcoin rebase is finished.

@phelixbtc phelixbtc closed this May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants