Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown the pool now to avoid delayed shutdownchannelgroupexception #15

Merged
merged 1 commit into from May 31, 2016

Conversation

weiyu2001
Copy link
Contributor

This is to fix the mvn -q test -DclassName=TestAsyncTcpTransport run failure with ShutdownChannelGroupException at the end

@jefft0 jefft0 merged commit 655b732 into named-data:master May 31, 2016
@weiyu2001
Copy link
Contributor Author

@jefft0 those exceptions are normal behavior under abnormal network connectivity. Some are thrown/logged inside AsyncTcpTransport and the rest are caught/logged by the test code trying to send packets while server is down. It is difficult to time when the send will throw exception because of the async timing of the send and reconnect. I can ignore those exceptions caught by test and not log them or simply log one line to show test procession but there will be other exceptions logged inside AsyncTcpTransport. Or I can turn off all logging for the whole test run (sounds like cheating). You have any better idea? please advise.

@jefft0
Copy link
Contributor

jefft0 commented Jun 2, 2016

OK if it's what you expected. I don't have a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants