Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote prefix registration #6

Merged
merged 15 commits into from Mar 6, 2015
Merged

Remote prefix registration #6

merged 15 commits into from Mar 6, 2015

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Feb 24, 2015

No description provided.

@jefft0
Copy link
Contributor

jefft0 commented Feb 25, 2015

In .gitignore, you replaced /target and examples/target with just "target". Does that mean you want to ignore any directory or file named "target" that may be created now or any time in the future?

@abrown
Copy link
Contributor Author

abrown commented Feb 25, 2015

That was the thought; if you think the library could ever have a target folder with code in it then this doesn't make sense.

@jefft0
Copy link
Contributor

jefft0 commented Feb 25, 2015

Not just a folder, a file too. Perhaps a future unit test generates a temporary file called target. The point is not to over reach out of the temporary convenience to save two lines in the .gitignore file.

@jefft0
Copy link
Contributor

jefft0 commented Feb 25, 2015

I should have said has a test (not temp) file called target.

@abrown
Copy link
Contributor Author

abrown commented Feb 25, 2015

Makes sense, it shouldn't be in this branch at all as it has little to do with the feature but the .gitignore wasn't covering built files; so for convenience I hid them.

@jefft0
Copy link
Contributor

jefft0 commented Feb 25, 2015

Thanks. I will definitely fix .gitignore in the master branch. But in looking for target folders, I found a bug for missing integration-tests/target. Please see http://redmine.named-data.net/issues/2560 and comment there.

@jefft0 jefft0 merged commit eac5963 into master Mar 6, 2015
@jefft0 jefft0 deleted the remote-prefix-registration branch March 10, 2015 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants