Add Python 3.7 support #39
Conversation
|
Hi @mattbennett , please take a look when you have a moment. I've added Python 3.7 tests to start preparing to support it since that's what we would like to do at Sohonet soon. |
test/conftest.py
Outdated
| @@ -40,7 +40,7 @@ def make_container(service_cls, config): | |||
| for c in all_containers: | |||
| try: | |||
| c.stop() | |||
| except: | |||
| except: # noqa: E722 | |||
There was a problem hiding this comment.
I think you want except: Exception here. Can't see a reason why we should be catching anything else.
Also, I wonder why we are reimplementing the container_factory here. Does nameko-sqlalchemy require stop instead of kill for teardown?
There was a problem hiding this comment.
@mattbennett You're right about the exception and we do not seem to require stop instead of kill either. I have removed the fixture and all tests are passing without reimplementing it 👍
There was a problem hiding this comment.
Nice! I poked around in the history and it turns out that this was ported from Nameko core before Nameko had its own pytest plugin, so that explains the need for reimplementation.
There was a problem hiding this comment.
That makes sense. Good to remove old code :)
|
Thanks @mattbennett ! Please merge it if you're happy. |
Preparing the library for Python 3.7.
After updating the
devrequirements, it seems to work fine and all the tests pass successfully.xenialsudoTravis keyword has been fully deprecateddevrequirements to the latest version:pylintfor Python 2pep8after upgradingflake8pytestdevextras, remove unused code.mysqlTravis service since we're user Docker containerspytestreferences in the documentation