Compat fixes #592
Merged
Compat fixes #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iky
approved these changes
Nov 22, 2018
iky
reviewed
Nov 22, 2018
| @@ -3,5 +3,5 @@ universal = 1 | |||
|
|
|||
| [flake8] | |||
| ignore = | |||
| max-line-length = 79 | |||
| max-line-length = 88 | |||
There was a problem hiding this comment.
This is a pre-cursor to just turning on black ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing nameko-amqp-retry against the v3 pre-release, I discovered two compatibility issues:
nameko.standalone.rpc(45034c1)expected_exceptionsandsensitive_argumentswere swallowed by theConsumer(720cdc3)c7a7ac2 adds tests to all built-in entrypoints verifying that
expected_exceptionsandsensitive_argumentscan be passed. 6768d1a fixes theTimerimplementation, which did not accept them.