Better config helpers API #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move `update_config` and `setup_config` helper methods from module and place them on config object itself. * Rename both helper context managers to `patch` and use `clear` argument of `patch` to replace the whole config. * Keep `setup` as simple method only (also straight on `config`)
mattbennett
reviewed
Jan 14, 2019
nameko/__init__.py
Outdated
| @pytest.yield_fixture | ||
| def memory_rabbit_config(): | ||
| with nameko.config.patch({"AMQP_URI": "memory://"}): | ||
| yield |
There was a problem hiding this comment.
It's a little confusing that this fixture is defined but not used. I think you can drop this and just demonstrate the decorator usage.
nameko/__init__.py
Outdated
|
|
||
| """ | ||
|
|
||
| config = self.data |
There was a problem hiding this comment.
Might be clearer to call this data. I was briefly confused and thought the implementation below was writing to the global config var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
patchis a better fit for the context manager name as it suggests that the config changes are returned back at exit:When migrating a few services to global config I learned that having also a decorator for setting up test function context config would be very handy:
I also placed these helpers straight on config object having them available straight away and making the config API clearer.