Global config improvement #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backward compatible passing of custom config to container and runner factories.
mattbennett
reviewed
Mar 11, 2019
test/testing/test_pytest_plugin.py
Outdated
|
|
||
| container_factory_fixture = container_factory_fixture() | ||
|
|
||
| container_factory = next(container_factory_fixture) |
There was a problem hiding this comment.
I think it would be easier to understand these tests if they used the testdir.runpytest approach like the other tests in this module. Is there a reason not to do that here?
iky
force-pushed
the
global-config
branch
4 times, most recently
from
030f8f7
to
66b78ca
Compare
mattbennett
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nameko 2.X backward compatible passing of custom config arguments to
container_factoryandrunner_factorytest helpers. Config patch is applied if a config dictionary is passed to these factories.