V3.0.0 rc with latest master #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added parameter eager to Timer for setting "fire first" mode * Wait for completion of service method Resolves: #303 * Don't forget on squash with commit before. rename self.event to self.worker_complete and don't send the unnecessary result to Event() * Add timer tests and apply feedback on previous merge request - Continue work from pull request #302 - Resolve #303 - Add tests for timer - Fix issue where exceptions inside timer worker caused exception in ServiceContainer * Apply review comments - Inline test service class creation - Add "tracker" fixture - Add passing kwargs to entrypoint constructor * Remove unnecessary assertion that container is not dead - Unnecessary as test is only testing the behaviour of using expected exceptions. It wouldn't be expected for the container to die even if the error wasn't expected. - Give tests where timing is important a bit more room
* Hide password in logged amqp uri * Remove duplicate test
* Use GitHub tool to implement license * Add NOTICE * Rename LICENSE to LICENSE.txt * Rename NOTICE to NOTICE.txt
* Updated Support to go to https://discourse.nameko.io/ Pointing to the new discussion forum rather than google groups. Keeping the google group line still there in case the old Q&A knowledge base hasn't been migrated to https://discourse.nameko.io/. Cheers * Update README.rst
* Make explicit that Rabbitmq is required for index page.
* Exceptions raised in shell will not be caught when not in TTY * Fix coverage issue, fix python 2.7 compatibility * Fix another incompatibility issue * Added no cover to code that is covered in subprocess * another missing line * Added comments explaining no cover
This particularly changed: celery/kombu@1160b92
Comply with pyyaml 5.1 security breaking changes
* Use generator for timer to avoid drift * Use itertools.count and consolidate eager processing
Describe and bump up version for v2.12.0 release
mattbennett
approved these changes
Mar 19, 2019
| "requests>=1.2.0", | ||
| "six>=1.9.0", | ||
| "werkzeug>=0.9", | ||
| "wrapt>=1.0.0", | ||
| ], | ||
| extras_require={ | ||
| 'dev': [ | ||
| "astroid==1.6.5", |
There was a problem hiding this comment.
Is this here because we pin it? I don't think astroid is used directly
There was a problem hiding this comment.
Oh yes, I see david's commit (1a72c70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making 3.0.0 release candidate up to date with latest master changes.